Review of "CyberGlow" version 1

Details Page Preview

A neon shape overlay with tinted rain, dust, and glitch flicker reacting to the music on the desktop background, plus optional neon window underglow.

Extension Homepage
https://github.com/visnudeva/CyberGlow

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove `preferences` from `metadata.json`. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 3. You shouldn't use spawn for something that can be done in d-bus (line 50 `lib/audio-pactl.js`). 4. `this._enabled` is a bad practice. Please remove that. 5. That can crash the GNOME Shell process (line 159 `lib/audio-visualizer.js`). Check with [`Gst.is_initialized`](https://gjs-docs.gnome.org/gst10~1.0/gst.is_initialized) before calling that. 6. Selective disable isn't allowed (line 232 `lib/underglow.js`). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
visnudeva posted a review
1. Removed preferences from metadata.json 2. Switched to connectObject() / disconnectObject() for signal cleanup 3. Replaced pactl spawn with PulseAudio D-Bus 4. Removed _enabled flags; lifecycle tracked via resources 5. Guarded GStreamer init with Gst.is_initialized() 6. Moved underglow on/off to full enable/disable in extension.js (no selective disable)