Review of "CyberGlow" version 2

Details Page Preview

A neon shape overlay with tinted rain, dust, and glitch flicker reacting to the music on the desktop background, plus optional neon window underglow.

Extension Homepage
https://github.com/visnudeva/CyberGlow

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Remove unnecessary try-catch wrapper (line 175 `lib/audio-visualizer.js`). 2. Don't get multiple instances of `this.getSettings()`. 3. `this.disconnectObject()` is wrong. `INSTANCE.disconnectObject(this)` is the correct way of doing it. Same issue for `this.connectObject()`. The correct way is `INSTANCE.connectObject('SIGNAL-NAME', CALLBACK, this)`;
JustPerfection posted a review
4. Remove `package.sh`.
visnudeva posted a review
1. Removed unnecessary try-catch, The Gst.init() wrapper in _ensureGst() is now a direct call without try-catch. 2. Cached settings (extension.js) , this._settings is set once in _enableInternal() and reused everywhere instead of calling this.getSettings() repeatedly. It's cleared in disable(). 3. Fixed connectObject / disconnectObject pattern Updated across all files to the correct GNOME Shell pattern: // Connect instance.connectObject('signal-name', callback, this); // Disconnect instance.disconnectObject(this); 4. package.sh deleted.