Review of "Touchpad Switcher" version 13

Details Page Preview

Touchpad Switcher allows you to easily toggle the touchpad on and off via the GNOME quick settings menu. It also includes an optional indicator to display the current touchpad state in the system tray. P.S. extension icon by icons8.com

Extension Homepage
https://github.com/gpawru/touchpad

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
14 Active
13 Rejected
12 Active
11 Active
10 Active
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Rejected
1 Active

Previous Reviews on this Version

JustPerfection waiting for author
Did you test the prefs in other languages, that line 6-22 `prefs.js` actually works?
gpawru posted a review
Oh, my bad. Yes, this thing works as intended. BUT the languages were not working correctly (I initially tested only 2 of them). The issue is that in the translations where I wasn't sure about correctness, I added "fuzzy" markers in the PO files for the new strings — thinking I was just leaving a marker for translators. For some reason I was convinced it doesn't affect MO files during build — and I was wrong. Fixed it, tested all languages.
gpawru auto- rejected
Auto-rejected because of new version 14 was uploaded
JustPerfection posted a review
gettext shouldn't work in global scope. You should move those lines to `fillPreferencesWindow()` and then they should work. `gettext` won't work before the default class init.
gpawru posted a review
> gettext shouldn't work in global scope. The gettext calls are wrapped in closures — _() returns a function, so the actual gettext() invocation happens lazily, only when called inside fillPreferencesWindow(). The gettext domain is already initialized by that point. Tested with multiple locales, works correctly.