GNOME Shell Extensions

Review of "Rectangle" version 31

Details Page Preview

Rectangle

by acristoffers

Magnet/Rectangle like manual tiling

Extension Homepage
https://github.com/acristoffers/gnome-rectangle
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:48 
    this.animationState = new AnimationState()
  • extension.js:50 
    this.gsettings = this.getSettings()
  • extension.js:49 
    this.keyManager = new ShortcutsManager()
  • extension.js:54 
    this.menu = new PanelMenu.Button(0, "Rectangle", false)

All Versions

Version Status
32 Active
31 Rejected
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

Álan e Sousa posted a review
`EGO-L-005` seems to be false-negative, since I do set those to null in the disable function. For `EGO-P-006`, should I just not compile the schemas anymore?
JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup.