Review of "Rectangle" version 35

Details Page Preview

Magnet/Rectangle like manual tiling

Extension Homepage
https://github.com/acristoffers/gnome-rectangle

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:315
    app.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • extension.js:62
    this.animationState = new AnimationState()
  • extension.js:64
    this.gsettings = this.getSettings()
  • extension.js:63
    this.keyManager = new ShortcutsManager()
  • extension.js:68
    this.menu = new PanelMenu.Button(0, 'Rectangle', false)

All Versions

Version Status
35 Active
34 Active
33 Active
32 Active
31 Rejected
30 Rejected
29 Active
28 Active
27 Active
26 Active
25 Active
24 Active
23 Active
22 Active
21 Active
20 Active
19 Active
18 Active
17 Rejected
16 Rejected
15 Active
14 Active
13 Rejected
12 Active
11 Active
10 Rejected
9 Active
8 Active
7 Active
6 Active
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

GdH active