Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.
EGO-A-005 manual_review
extensions should not access the clipboard directly
Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.
TcIndicator.js:290
St.Clipboard.get_default()
| Version | Status |
|---|---|
| 37 | Unreviewed |
| 36 | Rejected |
| 35 | Rejected |
| 34 | Active |
| 33 | Active |
| 32 | Active |
| 31 | Active |
| 30 | Rejected |
| 29 | Active |
| 28 | Rejected |
| 27 | Active |
| 26 | Rejected |
| 25 | Active |
| 24 | Rejected |
| 23 | Active |
| 22 | Active |
| 21 | Rejected |
| 20 | Rejected |
| 19 | Active |
| 18 | Active |
| 17 | Active |
| 16 | Active |
| 15 | Active |
| 14 | Active |
| 13 | Active |
| 12 | Active |
| 11 | Active |
| 10 | Active |
| 9 | Active |
| 8 | Active |
| 7 | Active |
| 6 | Active |
| 5 | Active |
| 4 | Active |
| 3 | Active |
| 2 | Inactive |
| 1 | Active |
1. You should call `abort()` on disable or destroy: - line 34 `google.js` - line 254 `llm.js` - line 56 `tts.js` [`Soup.Session.abort()`](https://gjs-docs.gnome.org/soup30~3.0/soup.session#method-abort) 2. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Instead of commenting those test blocks, please remove them. 4. Remove version from the import (line 4 `llm.js`). 5. Remove `extension-id` and `locale` from `metadata.json`: [EGO Review Guidelines: stable shell version](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 6. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. Avoid sending large diff. It is hard to review and takes time to review.