Review of "ChromaLeon" version 33

Details Page Preview

Change your system accent colors dynamically based on your wallpaper. Adapt your GNOME Shell, Adwaita apps, adw-gtk3, and folder/app icons like a chameleon.

Extension Homepage
https://github.com/Fabito02/ChromaLeon

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
1.5.3 (73) Active
1.5.3 (72) Rejected
1.5.3 (71) Rejected
1.5.3 (70) Rejected
1.5.3 (69) Rejected
1.5.2 (68) Active
1.5.2 (67) Rejected
1.5.0 (66) Active
1.4.1 (65) Rejected
1.4.0 (64) Active
1.3.0 (63) Active
1.2.7 (62) Active
1.2.7 (61) Rejected
1.2.6 (60) Active
1.2.5 (59) Active
1.2.4 (58) Active
1.2.4 (57) Rejected
1.2.3 (56) Rejected
1.2.0 (55) Inactive
1.2.0 (54) Rejected
1.1.0 (53) Rejected
1.1.0 (52) Rejected
1.0.0 (51) Inactive
50 Inactive
49 Inactive
48 Inactive
47 Inactive
46 Inactive
45 Inactive
44 Inactive
43 Rejected
42 Rejected
41 Inactive
40 Inactive
39 Rejected
38 Rejected
37 Rejected
36 Inactive
35 Inactive
34 Inactive
33 Rejected
32 Inactive
31 Rejected
30 Inactive
29 Inactive
28 Inactive
27 Inactive
26 Inactive
25 Inactive
24 Inactive
23 Rejected
22 Rejected
21 Rejected
20 Inactive
19 Rejected
18 Rejected
17 Rejected
16 Rejected
15 Rejected
14 Rejected
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. This is getting really too much for a GNOME Shell extension. Tampering with user config files isn't really a good thing, especially without backing up the original. Even after backup, browsers can expect something new in the updates which makes the original back useless. I highly recommend to move the logic out of this extension to an app and use d-bus to communicate between them: [D-Bus Guide](https://gjs.guide/guides/gio/dbus.html) That way, the app is just a dependency for this extension. 2. Please don't use old imports (line 1-2 `utils/firefoxUtils.js`).
Fabito02 posted a review
1. Thanks for the suggestions. On second thought, the extension is really getting too large, and an app would be a good idea. Perhaps I'll dedicate some of my time to porting the vast majority of the functions to an app, to reduce the bloat of the extension. I also didn't pay attention to backing up user files, so I should have kept that in mind. 2. Okay, I'll fix that. Thanks for the review, I'll focus updates on translations for now, while I work on creating an app.
Fabito02 posted a review
Considering the possibility of creating a separate app, I imagine it could disrupt the flow of users who already use the extension. Furthermore, it might detract from the idea of being practical if the user needs to install an extension and also a separate app. With that in mind, I'm going to focus on trying to optimize the logic of what I already have in the extension and avoid adding new functions, aiming for better performance and less load on GNOME Shell. Thank you for your review, I will take it into consideration.
JustPerfection posted a review
Actually, we had some popular extensions before but now they are separate apps. Their apps are even more popular. For example, Fly-Pie is now Kando: https://github.com/kando-menu/kando Even runs on other platforms as an app. Anyway, since GNOME Shell extension is GJS, you are already there. You can create a JS app with it.
Fabito02 posted a review
You're absolutely right about that. I think it would be good to do that, and it might also be more performant than an extension for so many simultaneous tasks. I'll focus on turning this into something written in Rust, like an application. Thanks for the suggestion.