Review of "ChromaLeon" version 2.5.0 (90)

Details Page Preview

Change your system accent colors dynamically based on your wallpaper. Adapt your GNOME Shell, Adwaita apps, adw-gtk3, and folder/app icons like a chameleon.

Extension Homepage
https://github.com/Fabito02/ChromaLeon

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils/themeUtils.js:126
    mainFile.load_contents(null)

All Versions

Version Status
2.5.1 (91) Active
2.5.0 (90) Rejected
2.4.2 (89) Active
2.4.1 (88) Active
2.4.0 (87) Rejected
2.3.2 (86) Active
2.3.1 (85) Active
2.3.0 (84) Rejected
2.2.0 (83) Active
2.1.1 (82) Active
2.1.0 (81) Active
2.0.0 (80) Active
2.0.0 (79) Rejected
1.5.7 (78) Inactive
1.5.6 (77) Inactive
1.5.5 (76) Inactive
1.5.5 (75) Rejected
1.5.4 (74) Inactive
1.5.3 (73) Inactive
1.5.3 (72) Rejected
1.5.3 (71) Rejected
1.5.3 (70) Rejected
1.5.3 (69) Rejected
1.5.2 (68) Inactive
1.5.2 (67) Rejected
1.5.0 (66) Inactive
1.4.1 (65) Rejected
1.4.0 (64) Inactive
1.3.0 (63) Inactive
1.2.7 (62) Inactive
1.2.7 (61) Rejected
1.2.6 (60) Inactive
1.2.5 (59) Inactive
1.2.4 (58) Inactive
1.2.4 (57) Rejected
1.2.3 (56) Rejected
1.2.0 (55) Inactive
1.2.0 (54) Rejected
1.1.0 (53) Rejected
1.1.0 (52) Rejected
1.0.0 (51) Inactive
50 Inactive
49 Inactive
48 Inactive
47 Inactive
46 Inactive
45 Inactive
44 Inactive
43 Rejected
42 Rejected
41 Inactive
40 Inactive
39 Rejected
38 Rejected
37 Rejected
36 Inactive
35 Inactive
34 Inactive
33 Rejected
32 Inactive
31 Rejected
30 Inactive
29 Inactive
28 Inactive
27 Inactive
26 Inactive
25 Inactive
24 Inactive
23 Rejected
22 Rejected
21 Rejected
20 Inactive
19 Rejected
18 Rejected
17 Rejected
16 Rejected
15 Rejected
14 Rejected
13 Inactive
12 Inactive
11 Inactive
10 Inactive
9 Inactive
8 Inactive
7 Inactive
6 Rejected
5 Inactive
4 Inactive
3 Inactive
2 Inactive
1 Rejected

Previous Reviews on this Version

Fabito02 posted a review
Apologies for the massive diff; I had to completely refactor the CSS to align with the GNOME 51 CSS, and I’ve reorganized everything into folders for better structure.
JustPerfection rejected
Reviewed. Just need to fix that issue mentioned by shexli. Also, you can move the css and svg files to gresources. You can look into my extension if you need an example: https://gitlab.gnome.org/jrahmatzadeh/just-perfection/-/blob/026dc7c473abacb084f3d2f9262a43c5a3a68144/src/lib/Prefs/Prefs.js#L181
Fabito02 posted a review
This warning isn't a real problem. It needed to be synchronous because it only runs on disable, and in this case, it wasn't handling an asynchronous operation very well. And thank you for the suggestion! I'll take a look at it.
JustPerfection posted a review
It is because it can freeze the shell process.