Review of "Weather O'Clock" version 50.4 (23)

Details Page Preview

Display the current weather inside the pill next to the clock. GNOME Weather is required for this extension to work.

Extension Homepage
https://github.com/CleoMenezesJr/weather-oclock

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:491
          this._timers.longTermUpdate = GLib.timeout_add_seconds(
            GLib.PRIORITY_LOW,
            600,
            () => {
              if (!this._weather) return GLib.SOURCE_REMOVE;
              if (this._monitor.connectivity === Gio.NetworkConnectivity.LOCAL)
                return GLib.SOURCE_CONTINUE;
            

EGO-L-007 warning

main loop sources should be removed before being recreated

Main loop sources should be removed before creating a new source on the same field.

Remove main loop sources

  • extension.js:404
              this._timers.description = GLib.timeout_add(GLib.PRIORITY_LOW, 1500, () => {
                this._timers.description = null;
                if (!this._weather) return GLib.SOURCE_REMOVE;
                this._showDescription(description);
                return GLib.SOURCE_REMOVE;
              })

All Versions

Version Status
50.4 (24) Active
50.4 (23) Active
50.3 (22) Active
50.2 (21) Active
50.2 (20) Rejected
50.1 (19) Rejected
50.0 (18) Active
49.0 (17) Active
48.0 (16) Active
48.0 (15) Rejected
47.0 (14) Active
46.2 (13) Active
46.1 (12) Active
11 Active
10 Rejected
9 Rejected
8 Active
7 Active
6 Active
5 Active
4 Active
3 Rejected
2 Active
1 Active

Previous Reviews on this Version

JustPerfection active