Review of "Google Tasks" version 1

Details Page Preview

Visualiza y gestiona tus tareas de Google Tasks desde el panel de GNOME

Extension Homepage
https://github.com/jhcoder/task_gnome_extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 5

Shexli found 5 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • po/meson.build
    po/meson.build
  • po/en/LC_MESSAGES/google-tasks-extension.mo
    po/en/LC_MESSAGES/google-tasks-extension.mo

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • gschemas.compiled
    gschemas.compiled

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • oauthManager.js:19
    new Secret.Schema(
        'org.gnome.shell.extensions.google-tasks',
        Secret.SchemaFlags.NONE,
        {
            'service': Secret.SchemaAttributeType.STRING,
            'account': Secret.SchemaAttributeType.STRING
        }
    )

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:126
            connectItem.connect('activate', () => {
                this._startAuthentication();
            })
  • extension.js:61
            this.menu.connect('open-state-changed', (menu, isOpen) => {
                if (isOpen) {
                    // Verificar si la sesión se cerró desde Preferencias
                    if (this._isAuthenticated && this._settings.get_boolean('first-run')) {
                        this._isAuthenticated = fals
  • extension.js:208
            retryItem.connect('activate', () => {
                this._buildInitialMenu();
            })

EGO-M-005 warning

metadata session-modes must be omitted when only user mode is declared

Field `session-modes` should be omitted when it only contains `user`.

metadata.json must be well-formed

  • metadata.json
    session-modes=['user']

All Versions

Version Status
1 Unreviewed