Review of "Google Tasks" version 2

Details Page Preview

Visualiza y gestiona tus tareas de Google Tasks desde el panel de GNOME

Extension Homepage
https://github.com/jhcoder/task_gnome_extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • po/en.po
    po/en.po
  • po/meson.build
    po/meson.build
  • po/fr.po
    po/fr.po
  • po/google-tasks-extension.pot
    po/google-tasks-extension.pot

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:199
            this._connectItemId = connectItem.connect('activate', () => {
                this._startAuthentication();
            })
  • extension.js:284
            this._retryItemId = retryItem.connect('activate', () => {
                this._startAuthentication();
            })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

jhcoder2024 auto- rejected
Auto-rejected because of new version 3 was uploaded