Review of "Jira Checker" version 1

Details Page Preview

A GNOME Shell extension that monitors your assigned Jira tasks and displays them in the system tray with desktop notifications for new assignments.

Extension Homepage
https://github.com/gustavocoleta/jira-checker

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:62
          console.warn(
            '[Jira Checker] Extension not configured. Please set Jira credentials in preferences.',
          )
  • extension.js:158
    console.error(`[Jira Checker] Error checking tasks: ${error}`)
  • extension.js:188
                    console.error(
                      `[Jira Checker] HTTP error: ${message.get_status()}`,
                    )
  • extension.js:202
                    console.error(
                      `[Jira Checker] ${data.errorMessages.join(', ')}`,
                    )
  • extension.js:217
    console.error(`[Jira Checker] Parse error: ${error}`)
  • extension.js:223
    console.error(`[Jira Checker] Request error: ${error}`)
  • extension.js:412
    console.error(`[Jira Checker] Failed to open URL: ${error}`)
  • extension.js:425
    console.error(`[Jira Checker] Webhook error: ${error}`)
  • extension.js:429
    console.error(`[Jira Checker] Failed to call webhook: ${error}`)

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:389
    clutterText.connect('activate', () => confirm())
  • extension.js:379
        clutterText.connect('text-changed', () => {
          const text = clutterText.get_text();
          const upper = text.toUpperCase();
          if (text !== upper) {
            const pos = clutterText.get_cursor_position();
            clutterText.set_text(upper);
            clutterText.set_cursor_position(pos);
       

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

gustavocoleta auto- rejected
Auto-rejected because of new version 2 was uploaded