Review of "Jira Checker" version 3

Details Page Preview

Check for assigned Jira tasks with system tray notification

Extension Homepage
https://github.com/gustavocoleta/jira-checker

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:393
        dialog.connect('destroy', () => {
          clutterText.disconnect(textChangedId);
          clutterText.disconnect(activateId);
        })

All Versions

Version Status
1.1.1 (8) Active
1.1.0 (7) Active
6 Inactive
5 Inactive
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
1. Please remove `icon` from `metadata.json`. Not needed. 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations) If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions