Review of "Medialine" version 9

Details Page Preview

Shows currently playing media in the top bar in a minimal elegant way. - Enhanced support for PWA's with proper icon and window callback - Customisable icon in the top bar: supports app icon, album art, playing status or custom image - Full support for seeking, play pause, track change, shuffle and repeat from the popup only - When there are multiple media sources, shows all the players in a compact manner - Customisable text and background color to match with your theme >>> Please ⭐ the GitHub repo if you like the extension!!!

Extension Homepage
https://github.com/funinkina/medialine

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
11 Active
10 Active
9 Rejected
8 Rejected
7 Rejected
6 Inactive
5 Rejected
4 Rejected
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
All the connects you are doing in `helpers/expandableMediaRow.js` should have `this` for their 3rd parameter instead of `this.actor`. So you should do this instead: ```js 544 545 this.actor.disconnectObject(this); 546 this._art.disconnectObject(this); 547 this._progressTrack.disconnectObject(this); 548 for (const btn of [this._shuffleBtn, this._prevBtn, this._playBtn, this._nextBtn, this._repeatBtn]) 549 btn.disconnectObject(this); 550 this.actor.destroy(); 551 this.actor = null; 552 ``` Don't forget that shouldn't be wrapped with `if (this.actor) {`.