Review of "Lens" version 1

Details Page Preview

Spotlight-alike intelligent local search for GNOME. Find anything on your computer using privacy-respecting, AI-assisted semantic search. Can filter or answer typical AI questions about your own data without ever leaving your computer. Fast live preview of image, video, PDF, and Office document previews directly while browsing. Utilizes native GPU or NPU/TPU if available for acceleration.

Extension Homepage
https://github.com/cwittenberg/lens-for-gnome/tree/main/gnome-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:56
    St.Clipboard.get_default()
  • extension.js:101
    St.Clipboard.get_default()

All Versions

Version Status
8 Active
7 Rejected
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Don't need to use any parameters for `this.getSettings()` since you already have that in `metadata.json`. 2. You cannot create instance of objects in global scope (line 182 `runtime.js`). 3. You clearly know that class has `clearSelection()` method (line 785 `ui.js`). Same for line 455 `ui_preview_video.js`. 4. Don't check for something that always exist (line 580, 652 `ui_preview_video.js`). 5. Same property holding the timeout id for multiple timeouts (line 567, 729 `ui_preview_video.js`). 6. What's the reason for importing (line 74 `ui_preview_video.js`)? 7. Import at top of the file (line 71 `ui_preview_video.js`). 8. That can crash GNOME Shell (line 73 `ui_preview_video.js`). You should check with [gst.is_initialized](https://gjs-docs.gnome.org/gst10~1.0/gst.is_initialized) first. 9. What's the reason for this function checks (line 580 `ui_preview_video.js`)?