Review of "Lens" version 2

Details Page Preview

Spotlight-alike intelligent local search for GNOME. Find anything on your computer using privacy-respecting, AI-assisted semantic search. Can filter or answer typical AI questions about your own data without ever leaving your computer. Fast live preview of image, video, PDF, and Office document previews directly while browsing. Utilizes native GPU or NPU/TPU if available for acceleration.

Extension Homepage
https://github.com/cwittenberg/lens-for-gnome/tree/main/gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) manual_review 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:56
    St.Clipboard.get_default()
  • extension.js:101
    St.Clipboard.get_default()

All Versions

Version Status
8 Active
7 Rejected
6 Inactive
5 Inactive
4 Inactive
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
The instance is still there after disable (line 182 `runtime.js`): [EGO Review Guidelines: Destroy](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#destroy-all-objects)
cwittenberg posted a review
Thanks for your review. i made the adjustments as discussed. 1. removed parameters for `this.getSettings()` 2. Removed create instance of objects in global scope using factory 3. removed unnecessary clearselection functions`ui_preview_video.js` (forgot to remove ) 4. fixed: existance check (line 580, 652 `ui_preview_video.js`). 5. timeout id for multiple timeouts (line 567, 729 `ui_preview_video.js`). 6. removed unnecessary imports in ui_preview_video.js 8. Regarding check for GST. I made it guarded by Gst.is_initialized() to prevent crash 9. removed unnecessary checks in ui_preview_video.js