Review of "Places + Recent Indicator" version 1

Details Page Preview

Nautilus bookmarks and recent files in the top panel. Click a bookmarked folder to open it in Nautilus. Left-click a recent file to open it in its default application, right-click to reveal it in the file manager.

Extension Homepage
https://github.com/janvavra81/gnome-extension-recentplaces

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:174
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open)
                    this._rebuildMenu();
            })

All Versions

Version Status
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please use aysnc for reading file content since you are in shell process (line 22 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) Also, I highly recommend to only send the 45+ packages for new extensions. Not many people using older GNOME Shells and for new extensions, it can just make it hard to maintain.