Review of "Places + Recent Indicator" version 2

Details Page Preview

Nautilus bookmarks and recent files in the top panel. Click a bookmarked folder to open it in Nautilus. Left-click a recent file to open it in its default application, right-click to reveal it in the file manager.

Extension Homepage
https://github.com/janvavra81/gnome-extension-recentplaces

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:25
    GLib.file_get_contents(path)

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:177
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open)
                    this._rebuildMenu();
            })

All Versions

Version Status
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Please fix the issues mentioned in the shexli and send it again. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions