Review of "Notification Badge" version 1

Details Page Preview

Show the notification count of applications on their icon.

Extension Homepage
https://codeberg.org/icsanyi/gnome-notification-badge

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/notification-badge.gschema.xml
    id='org.gnome.shell.extensions.notification-badge' path='/org/gnome/shell/extensions/notification-badge/'

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:8
        getPreferencesWidget() {
            const page = new Adw.PreferencesPage();
            const settings = this.getSettings();
            page.add(this.getBehaviorGroup(settings));
            page.add(this.getAppearanceGroup(settings));
            return page;
        }

All Versions

Version Status
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Didn't review. Shexli issues need to be addressed first. Also, please use empty new lines between functions and classes. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Csányi István posted a review
It is written in typescript and the typescript compiler does not have an option to preserve empty lines.
JustPerfection posted a review
Prettier would do the job for empty new lines.
JustPerfection posted a review
Please fix the lines too and send it again. Thanks!
Csányi István posted a review
Prettier does not add empty newlines
JustPerfection posted a review
I recommend to look at the config of this extension: https://github.com/crisidev/mouse-follows-focus