Approved but: 1. `Destroyable` in `util.js` is unnecessary. You can simply extend: ```js import * as Signals from 'resource:///org/gnome/shell/misc/signals.js'; Class SomeClassName extends Signals.EventEmitter { } ``` You don't need `super.destroy()` after that: - line 70 `notification.js` - line 29 `decorator.js` 2. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). Some places you are still using the `connect()` and holding signal id. 3. It can be much easier to read if you `disconnectObject()` in disable directly instead of using `this.#destroySignal` (line 14 `extension.js`). You can also add `donations` to the `metadata.json`, so people can donate to you if they want: [Extension Anatomy: donations](https://gjs.guide/extensions/overview/anatomy.html#donations)

Signals.EventEmitter is not a registered "destroyable type" so it would leak signals. (https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/main/js/misc/signalTracker.js#L156) I could change connect() calls to connectObject(), but if I have to call disconnect manually anyway (when self is not a destroyable type), there is not much point to it and just fills the global signal tracker with more objects for no reason.