GNOME Shell Extensions

Review of "IP/VPN Indicator" version 5

Details Page Preview

IP/VPN Indicator

by notj0n

Displays your IP address and VPN status in the top panel

Extension Homepage
https://github.com/notj0n/ip-vpn-indicator
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled 
    schemas/gschemas.compiled

All Versions

Version Status
6 Active
5 Rejected
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `schemas/gschemas.compiled`. Not needed for 45+ packages. 2. You shouldn't use spawn command to check whether an app is installed (line 79 `extension.js`): ```js GLib.find_program_in_path("tailscale"); ``` 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only).
notj0n posted a review
thanks for feedback, I've uploaded a new version