Review of "Disk Space (panel indicator)" version 1

Details Page Preview

Permanent panel icon showing the usage of a chosen volume; click it to list every mounted volume (internal and external) with its Nautilus name.

Extension Homepage
https://github.com/Lokoyote/Diskspace

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • mounts.js:56
    GLib.file_get_contents('/proc/mounts')

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Where is the git url? Is this code generated by AI? If so, we have a rule for that: [EGO Review Guidelines: AI](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#extensions-must-not-be-ai-generated)
Lokoyote posted a review
The git URL is there : https://github.com/Lokoyote/Diskspace No. I wrote the extension myself. I did use AI occasionally as an assistant (for explanations and some code suggestions), but I reviewed, understood, and integrated all the code myself. I can edit the AI-generated comments to make them much more detailed and make the code look a bit less polished. I'm not an experienced programmer. There are some functions I'm not familiar with, and I did ask the AI to help me write those parts of the code.
JustPerfection rejected
Didn't review since shexli issues need to be fixed. Also, please remove the xml file in the root.
JustPerfection posted a review
and don't forget to add the git url to the `metadata.json`.
Lokoyote posted a review
I was surprised not finding the shexli tool but I understand. It's a great tool to help devs. You're right, I didn't remove the xml...