Review of "Disk Space (panel indicator)" version 2

Details Page Preview

Permanent panel icon showing the usage of a chosen volume; click it to list every mounted volume (internal and external) with its Nautilus name.

Extension Homepage
https://github.com/Lokoyote/Diskspace

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • mounts.js:51
    GLib.file_get_contents('/proc/mounts')

All Versions

Version Status
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. The XML file should be inside `schemas` folder. 2. Please use aysnc for reading file content since you are in shell process (line 51 `extension.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
Lokoyote posted a review
Thank you for the review, I adapted the code