Review of "Shelly Cover Controller" version 1

Details Page Preview

Control your Shelly 2PM cover directly from the top panel.

Extension Homepage
https://github.com/firebirdberlin/shelly-cover-control

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • extension.js:120
    GLib.file_get_contents(this._stateFile)

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 9 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:88
    console.log('Shelly: Desktop Unlocked / Resumed. Waiting for network...')
  • extension.js:110
    console.log('Shelly: Running post-resume discovery scan.')
  • extension.js:127
    console.log('Shelly: No saved state found.')
  • extension.js:267
    console.log(`Shelly: Skipping ${deviceInfo.id} (${ip}) because it is not in cover mode.`)
  • extension.js:271
    console.log(`Shelly: Could not verify features for device at ${ip}`)
  • extension.js:60
    console.error(`Failed to open donation link: ${error.message}`)
  • extension.js:137
    console.error(`Shelly: Failed to save state file: ${error.message}`)
  • extension.js:205
    console.error(`Failed to launch avahi-browse: ${e.message}`)
  • extension.js:321
    console.error(`Failed to open Web UI for ${this._selectedShellyIp}: ${error.message}`)

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

firebiredberlin auto- rejected
Auto-rejected because of new version 2 was uploaded