Review of "Shelly Cover Control" version 4

Details Page Preview

Control your Shelly 2PM cover directly from the top panel.

Extension Homepage
https://github.com/firebirdberlin/shelly-cover-control

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:524
    socket.connect(remote, null)

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `screenshot.png`: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Remove version from the import (line 6 `extension.js`). 3. Just a recommendation: While `Gio.AppInfo.launch_default_for_uri` can throw, it's not needed to use try-catch wrapper for it. GNOME Shell also don't use the wrapper for that. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions