Review of "Ping Indicator++" version 1

Details Page Preview

Displays ping latency in the top bar, with optional sound and bar color alert when the network is down. Semi-rewrite, updated fork of ping_indicator.

Extension Homepage
https://github.com/sig9sec/ping_indicator_plusplus

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • .gitignore
    .gitignore

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:59
            GLib.timeout_add(GLib.PRIORITY_DEFAULT, 0, () => {
              if (this._inError) this._applyErrorStyle(true);
              return GLib.SOURCE_REMOVE;
            })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

sig9 auto- rejected
Auto-rejected because of new version 2 was uploaded