Review of "Ping Indicator++" version 3

Details Page Preview

Displays ping latency in the top bar, with optional sound and bar color alert when the network is down. Semi-rewrite, updated fork of ping_indicator.

Extension Homepage
https://github.com/sig9sec/ping_indicator_plusplus

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
7 Active
6 Rejected
5 Rejected
4 Active
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Please remove `stylesheet.css` since you are not using it: [EGO Review Guidelines: unnecessary files](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#don-t-include-unnecessary-files) 2. Use `console.*` instead of `log()`. Logs should be only available on debug mode. For debug use `console.debug()` instead of `console.log()`: [Port Guide 45: Logging](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#logging) 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup. 4. You cannot use spawn command to play sound (line 149 `extension.js`): ```js let player = global.display.get_sound_player(); let file = Gio.File.new_for_path('PATH TO THE FILE'); player.play_from_file(file, 'title', null); ``` Or play audio form theme: ```js player.play_from_theme('sound name', 'title', null); ``` If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
sig9 posted a review
Thanks for your review. I pushed a new version, everything reported should be fixed. Best