Review of "Proxy Switcher (Profile Management)" version 1

Details Page Preview

Take control of your proxy connections from the Top Panel. Effortlessly enable, disable, and switch between multiple proxy profiles in seconds.

Extension Homepage
https://github.com/seydef/proxy-switcher

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 11 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:57
    console.log(`ProxyManager: Applying profile "${profile.name}" (mode: ${profile.mode})`)
  • extension.js:93
    console.log(`ProxyManager: Successfully applied profile "${profile.name}"`)
  • extension.js:278
    console.log('ProxySwitcher: Enabling extension')
  • extension.js:283
    console.log('ProxySwitcher: Extension enabled successfully')
  • extension.js:290
    console.log('ProxySwitcher: Disabling extension')
  • extension.js:297
    console.log('ProxySwitcher: Extension disabled successfully')
  • extension.js:32
    console.error('ProxyManager: Failed to parse profiles:', e)
  • extension.js:42
    console.error('ProxyManager: Failed to save profiles:', e)
  • extension.js:97
    console.error(`ProxyManager: Failed to apply profile "${profile.name}":`, e)
  • extension.js:285
    console.error('ProxySwitcher: Failed to enable extension:', e)

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.proxy-switcher.gschema.xml
    id='org.gnome.shell.extensions.seydef.proxy-switcher' path='/org/gnome/shell/extensions/seydef/proxy-switcher/'

All Versions

Version Status
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Wrong id and path in the XML file. 2. Use `org.gnome.shell.extensions.proxy-switcher` in `metadata.json`. 3. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). 4. Remove try-catch wrappers from enable and disable. 5. Please avoid doing too many logs. If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions