Review of "Proxy Switcher (Profile Management)" version 3

Details Page Preview

Take control of your proxy connections from the Top panel. Effortlessly enable, disable, and switch between multiple proxy profiles in seconds.

Extension Homepage
https://github.com/seydef/proxy-switcher

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:277
                this.menu.connect('open-state-changed', (menu, isOpen) => {
                    if (isOpen)
                        this._syncFromSystem();
                })
  • extension.js:417
                source.connect('destroy', () => {
                    this._notificationSource = null;
                })

All Versions

Version Status
5 Active
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

seydef auto- rejected
Auto-rejected because of new version 4 was uploaded