Review of "Pequén USB" version 1

Details Page Preview

Chilean Owl USBGuard Sentinel & History Extension for GNOME Shell

Extension Homepage
https://github.com/esfingex/pequen-usb

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `metadata.json` should only hold the standard `keys`. Please remove `license` key: [EGO Review Guidelines: unnecessary metadata keys](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#metadata-json-must-be-well-formed) 2. Better to use gettext instead of custom translation. Anyway, you cannot call functions in global scope: [EGO Review Guidelines: Initialization](https://gjs.guide/extensions/review-guidelines/review-guidelines.html#only-use-initialization-for-static-resources) 3. Unnecessary try-catch wrapper (line 83 `extension.js`). 4. Move to enable and don't make it global (line 38 `extension.js`). 5. Please use `connectObject()` and `disconnectObject()` so it is easier to track for cleanup (`extension.js` only). If you need any help with your extension you can ask us on: - [GNOME Extensions Matrix Channel](https://matrix.to/#/#extensions:gnome.org) - IRC Bridge: irc://irc.gimpnet.org/shell-extensions
esfingex posted a review
Hi @JustPerfection, Thank you very much for the detailed review! I have addressed all 5 points in new version: 1. Removed non-standard `license` key from metadata.json. 2. Migrated to native GNOME Shell gettext (initTranslations) and removed global scope custom translation script. 3. Removed redundant try-catch wrapper around DBus proxy instantiation. 4. Moved DBus proxy creation inside enable() scope. 5. Replaced manual signal tracking with connectObject() and disconnectObject() for clean lifecycle cleanup. Best regards!