Review of "Pequén USB" version 3

Details Page Preview

Chilean Owl USBGuard Sentinel & History Extension for GNOME Shell

Extension Homepage
https://github.com/esfingex/pequen-usb

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
5 Active
4 Active
3 Active
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection active
Approved but: 1. No need to use `this.initTranslation()` (line 39 `extension.js`): > Consider this method deprecated. > Only specify gettext-domain in metadata.json. > GNOME Shell can automatically initiate the translation for you > when it sees the gettext-domain key in metadata.json. [Port Guide 45: Extension Utils](https://gjs.guide/extensions/upgrading/gnome-shell-45.html#extensionutils) 2. That may make gettext confused for gathering the text (line 97-103 `extension.js`). I highly recommend to use `this.gettext()` directly or use `_()` after doing this on top: ```js import {Extension, gettext as _} from 'resource:///org/gnome/shell/extensions/extension.js'; ```