Review of "AppMenu" version 1

Details Page Preview

A macOS-inspired global menu for GNOME, bringing a clean top panel with application menus, window actions, navigation controls, and quick-access shortcuts.

Extension Homepage
https://github.com/ChathurangaBW/AppMenu

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 6 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • actions/fileActions.js:166
    console.log('[appmenu] No removable drives found')
  • actions/fileActions.js:84
    console.error(`[appmenu] Failed to parse udisksctl output: ${e}`)
  • actions/fileActions.js:90
    console.error(`[appmenu] Failed to run udisksctl: ${e}`)
  • actions/fileActions.js:121
    console.error(`[appmenu] Failed to power off device: ${e}`)
  • actions/fileActions.js:126
    console.error(`[appmenu] Failed to unmount device: ${e}`)
  • actions/fileActions.js:131
    console.error(`[appmenu] Failed to eject device: ${e}`)

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • menuManager.js:51
    GLib.file_get_contents('/etc/os-release')

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

All Versions

Version Status
1 Unreviewed