Review of "Saved Desks" version 8

Details Page Preview

Save and restore window layouts on workspaces (Requires GNOME set to 'Workspaces on primary display only').

Extension Homepage
https://github.com/loginone33/saved-desks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 10 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:16
    console.error(`[SavedDesks] ${msg}: ${err.message || err}`)
  • extension.js:18
    console.error(`[SavedDesks] ${msg}`)
  • extension.js:281
    console.error('[SavedDesks] Failed to get tile mode: ' + e)
  • extension.js:295
    console.error('[SavedDesks] Failed to get maximized state: ' + e)
  • extension.js:310
    console.error('[SavedDesks] Error maximizing window: ' + e)
  • extension.js:321
    console.error('[SavedDesks] Error unmaximizing window: ' + e)
  • extension.js:527
    console.error('[SavedDesks] Failed getting work area: ' + e)
  • extension.js:549
    console.error('[SavedDesks] Failed getting tile mode: ' + e)
  • extension.js:580
    console.error('[SavedDesks] CRITICAL ERROR IN _doSaveCurrentWorkspace: ' + e.message + ' ' + e.stack)
  • extension.js:815
    console.error('[SavedDesks] Failed getting work area: ' + e)

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:308
    window.maximize(Meta.MaximizeFlags.BOTH)
  • extension.js:319
    window.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:290
    window.get_maximized()

All Versions

Previous Reviews on this Version

JustPerfection rejected
Unnecessary `=== 'function'` checks should be removed.
loginone posted a review
If You could please check version 10. Hope it's fine. I'm on the extensions channnel and see You are very busy so I'm even more greatfull for quick reviewes of my small extension ;)