Review of "Saved Desks" version 9

Details Page Preview

Save and restore window layouts on workspaces (Requires GNOME set to 'Workspaces on primary display only').

Extension Homepage
https://github.com/loginone33/saved-desks

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 2 warning 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 10 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • extension.js:16
    console.error(`[SavedDesks] ${msg}: ${err.message || err}`)
  • extension.js:18
    console.error(`[SavedDesks] ${msg}`)
  • extension.js:279
    console.error('[SavedDesks] Failed to get tile mode: ' + e)
  • extension.js:289
    console.error('[SavedDesks] Failed to get maximized state: ' + e)
  • extension.js:304
    console.error('[SavedDesks] Failed to maximize: ' + e)
  • extension.js:314
    console.error('[SavedDesks] Failed to unmaximize: ' + e)
  • extension.js:516
    console.error('[SavedDesks] Failed getting work area: ' + e2)
  • extension.js:539
    console.error('[SavedDesks] Failed getting tile mode: ' + e)
  • extension.js:570
    console.error('[SavedDesks] CRITICAL ERROR IN _doSaveCurrentWorkspace: ' + e.message + ' ' + e.stack)
  • extension.js:802
    console.error('[SavedDesks] Failed getting work area: ' + e2)

EGO-C49-003 error

extensions targeting GNOME 49 must not call maximize or unmaximize with Meta.MaximizeFlags

This extension explicitly targets GNOME Shell 49 but still passes `Meta.MaximizeFlags` to `maximize()` or `unmaximize()`.

Meta.Window

  • extension.js:302
    window.maximize(Meta.MaximizeFlags.BOTH)
  • extension.js:312
    window.unmaximize(Meta.MaximizeFlags.BOTH)

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • extension.js:287
    window.get_maximized()

All Versions

Previous Reviews on this Version

loginone auto- rejected
Auto-rejected because of new version 10 was uploaded