Review of "Gridgets" version 2

Details Page Preview

GNOME widgets for your desktop. A GNOME widget extension that places clocks, weather, system monitors, notes, music, and more onto a desktop grid. * Place image, GIF, weather, time, notes, music, system monitors, and clipboard widgets on a desktop grid. * Access your system clipboard history locally to provide a clipboard history widget. * Drag, resize, and customise each widget independently.

Extension Homepage
https://github.com/rebatnaath/gridgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • utils/widgetUtils.js:87
    file.load_contents(null)

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • widgets/clipboard.js:118
    St.Clipboard.get_default()

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • widgets/media/index.js

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected

Previous Reviews on this Version

rw4th auto- rejected
Auto-rejected because of new version 3 was uploaded