Review of "Gridgets" version 3

Details Page Preview

GNOME widgets for your desktop. A GNOME widget extension that places clocks, weather, system monitors, notes, music, and more onto a desktop grid. * Place image, GIF, weather, time, notes, music, system monitors, and clipboard widgets on a desktop grid. * Access your system clipboard history locally to provide a clipboard history widget. * Drag, resize, and customise each widget independently.

Extension Homepage
https://github.com/rebatnaath/gridgets

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • widgets/clipboard.js:107
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:58
                this._screenTimeIndicator.menu.connect('open-state-changed', (_menu, isOpen) => {
                    this._screenTimeIndicator._onOpenStateChanged(_menu, isOpen);
                })

All Versions

Version Status
3 Unreviewed
2 Rejected
1 Rejected