Review of "AlbumWM" version 50.0 (2)

Details Page Preview

Scrollable tiling extension for GNOME Shell (PaperWM fork). User guide: https://github.com/poli0iq/albumwm/blob/main/docs/user_guide.md Star the repo: https://github.com/poli0iq/albumwm

Extension Homepage
https://albumwm.0iq.dev

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 8 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • wm/tiling.js:169
    console.error(e)
  • wm/tiling.js:2255
    console.error('#winprops', `${overwriteSpace} is not a valid index. Ignoring.`)
  • wm/tiling.js:445
    console.warn('invalid preferredWidth value')
  • wm/tiling.js:457
    console.warn('invalid preferredWidth unit:', `'${prop.unit}'`, "(should be 'px' or '%')")
  • wm/tiling.js:771
    console.warn(`clone/window position-changed recursive call: ${w.title}`)
  • wm/tiling.js:1505
    console.warn(`MONITORS_CHANGED: no primary monitor, 'layout' on spaces call ${called}`)
  • wm/tiling.js:1816
    console.warn('window already registered', metaWindow.title)
  • wm/tiling.js:2273
            console.warn('#winprops', `overwriteSpace with index ${spaceIndex} does not exist. \
    Opening "${metaWindow?.title}" on current space.`)

EGO-P-004 error

GSettings schema XML filename must match schema id

GSettings schema filename must match `<schema-id>.gschema.xml`.

GSettings Schemas

  • schemas/org.gnome.shell.extensions.albumwm.gschema.xml
    id='org.gnome.shell.extensions.albumwm.keybindings' path='/org/gnome/shell/extensions/albumwm/keybindings/'

All Versions

Version Status
50.0 (2) Unreviewed
50.0.0 (1) Rejected