Review of "Dual Audio Hub" version 1

Details Page Preview

Quick top-bar toggle for Dual Bluetooth Audio streaming on Linux via PipeWire

Extension Homepage
https://github.com/Pardhu0547s/Dual_Bluetooth_Linux

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2

Shexli found 2 issues that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:135
            this._systemIndicator._toggle.connect('clicked', () => {
                if (this._systemIndicator._toggle.checked) {
                    this._startDualStream();
                } else {
                    this._stopDualStream();
                }
            })
  • extension.js:145
            toggle.volSlider1.slider.connect('notify::value', () => {
                if (this._targetSink1) {
                    this._setVolume(this._targetSink1.id, toggle.volSlider1.value);
                }
            })
  • extension.js:150
            toggle.volSlider2.slider.connect('notify::value', () => {
                if (this._targetSink2) {
                    this._setVolume(this._targetSink2.id, toggle.volSlider2.value);
                }
            })

EGO-L-004 warning

main loop sources should be removed in disable()

Main loop sources assigned in `enable()` are missing matching removals in `disable()` or its helper methods.

Remove main loop sources

  • extension.js:369
                GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
                    const proc2 = Gio.Subprocess.new(
                        [
                            'pw-loopback',
                            '--name', 'Dual_Slave_Stream',
                            '-i', 'node.latency=2048/48000',
                
  • extension.js:382
                    GLib.timeout_add(GLib.PRIORITY_DEFAULT, 500, () => {
                        this._fixSlaveStreamLinks();
                        this._setDefaultMasterSink();
                        return GLib.SOURCE_REMOVE;
                    })

All Versions

Version Status
1 Unreviewed