Review of "Dual Audio Hub" version 2

Details Page Preview

Quick top-bar toggle for Dual Bluetooth Audio streaming on Linux via PipeWire

Extension Homepage
https://github.com/Pardhu0547s/Dual_Bluetooth_Linux

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:137
            this._systemIndicator._toggle.connect('clicked', () => {
                if (this._systemIndicator._toggle.checked) {
                    this._startDualStream();
                } else {
                    this._stopDualStream();
                }
            })
  • extension.js:149
            toggle.volSlider1.slider.connect('notify::value', () => {
                if (this._volDebounce1) GLib.Source.remove(this._volDebounce1);
                this._volDebounce1 = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                    this._volDebounce1 = 0;
                    if (this._targetS
  • extension.js:159
            toggle.volSlider2.slider.connect('notify::value', () => {
                if (this._volDebounce2) GLib.Source.remove(this._volDebounce2);
                this._volDebounce2 = GLib.timeout_add(GLib.PRIORITY_DEFAULT, 50, () => {
                    this._volDebounce2 = 0;
                    if (this._targetS

All Versions

Version Status
2 Unreviewed
1 Rejected