Review of "Fisheye Dock" version 1

Details Page Preview

A Dash to Dock fork with high-resolution fish-eye magnification, spring motion, seamless rounded material, reflections, adaptive light/dark appearance and structural divider controls.

Extension Homepage
https://github.com/dino65-dev/dash-to-dock

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 6

Shexli found 6 issues that may need reviewer attention.

EGO-I-004 warning

extensions should not use imports._gi directly

Direct use of `imports._gi` is discouraged in extensions.

InjectionManager

  • utils.js:463
    Gi.gobject_prototype_symbol
  • utils.js:464
    Gi.gobject_prototype_symbol
  • utils.js:466
    Gi.hook_up_vfunc_symbol

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • locationsWorker.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • docking.js:264
    this._staticBox = new Clutter.ActorBox()
  • macDockEffects.js:297
                this._timeline = new Clutter.Timeline({
                    actor: this._layer,
                    duration: 1000,
                })

EGO-L-001 warning

extension must not create GObject instances or modify shell before enable()

Resource creation or signal/source setup was found outside `enable()`.

Only use initialization for static resources

  • appIcons.js:46
    tracker = Shell.WindowTracker.get_default()

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • appIconIndicators.js:270
            this._area = new IndicatorDrawingArea({
                x_expand: true,
                y_expand: true,
            })
  • docking.js:264
    this._staticBox = new Clutter.ActorBox()

EGO-C45-001 warning

45+ preferences should use fillPreferencesWindow instead of getPreferencesWidget

45+ preferences code should use `fillPreferencesWindow()` instead of `getPreferencesWidget()`.

Preferences

  • prefs.js:1176
        getPreferencesWidget() {
            const settings = new DockSettings(this);
            const {widget} = settings;
            return widget;
        }

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

Spedrox Sac auto- rejected
Auto-rejected because of new version 2 was uploaded