GNOME Shell Extensions

Review of "Fisheye Dock" version 2

Details Page Preview

Fisheye Dock

by spedrox

A Dash to Dock fork with high-resolution fish-eye magnification, spring motion, seamless rounded material, reflections, adaptive light/dark appearance and structural divider controls.

Extension Homepage
https://github.com/dino65-dev/dash-to-dock
No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-I-004 warning

extensions should not use imports._gi directly

Direct use of `imports._gi` is discouraged in extensions.

InjectionManager

  • utils.js:463 
    Gi.gobject_prototype_symbol
  • utils.js:464 
    Gi.gobject_prototype_symbol
  • utils.js:466 
    Gi.hook_up_vfunc_symbol

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • locationsWorker.js

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • docking.js:264 
    this._staticBox = new Clutter.ActorBox()

All Versions

Version Status
2 Unreviewed
1 Rejected