Review of "Notificate" version 1

Details Page Preview

Show notification banners immediately and stack them instead of queueing them one at a time. New banners appear underneath the previous ones, up to a configurable maximum (default 5). Setting the maximum to 1 reproduces the default GNOME behaviour. Also adds options for on-screen position and a minimal banner layout.

Extension Homepage
https://github.com/gabe-grinspan/notificate

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 4

Shexli found 4 issues that may need reviewer attention.

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • .gitignore
    .gitignore
  • .git/index
    .git/index
  • .git/description
    .git/description
  • .git/ORIG_HEAD
    .git/ORIG_HEAD
  • .git/HEAD
    .git/HEAD
  • .git/config
    .git/config
  • .git/COMMIT_EDITMSG
    .git/COMMIT_EDITMSG
  • .git/packed-refs
    .git/packed-refs
  • .git/FETCH_HEAD
    .git/FETCH_HEAD
  • .git/hooks/pre-push.sample
    .git/hooks/pre-push.sample

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • extension.js:173
            this._box = new St.BoxLayout({
                orientation: Clutter.Orientation.VERTICAL,
                x_expand: true,
                y_expand: true,
                reactive: false,
            })

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:756
        disable() {
            this._stack?.destroy();
            this._stack = null;
        }

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
Didn't review. The shexli issues need to be fixed first. Also, please remove session modes from `metadata.json`.