Review of "Notificate" version 2

Details Page Preview

Show notification banners immediately and stack them instead of queueing them one at a time. New banners appear underneath the previous ones, up to a configurable maximum (default 5). Setting the maximum to 1 reproduces the default GNOME behaviour. Also adds options for on-screen position and a minimal banner layout.

Extension Homepage
https://github.com/gabe-grinspan/notificate

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
2 Unreviewed
1 Rejected

Previous Reviews on this Version

gabe-grinspan posted a review
@JustPerfection I know that you requested I remove `session-modes` from the manifest.json, but my extension requires permissions on unlock. Otherwise it gets bypassed and the default GNOME behavior reappears. Otherwise I have fixed the shexli issues. Although it is worth noting that the shexli pypi package does not install cleanly without manually installing different, older versions of the dependencies.
gabe-grinspan posted a review
@JustPerfection I know that you requested I remove `session-modes` from the manifest.json, but my extension requires permissions on unlock. Otherwise it gets bypassed and the default GNOME behavior reappears. Otherwise I have fixed the shexli issues. Although it is worth noting that the shexli pypi package does not install cleanly without manually installing different, o versions of the dependencies.