Review of "Lupa OCR" version 1

Details Page Preview

Capture text from screen with OCR and search the web instantly. Like Google's Circle to Search but built into GNOME.

Extension Homepage
https://github.com/dznass-cmd/lupa-ocr-extension

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 2 manual_review 1

Shexli found 3 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:366
    St.Clipboard.get_default()
  • extension.js:370
    St.Clipboard.get_default()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • install.sh
    install.sh

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:187
    this._buttonPressId = this._overlay.connect('button-press-event', this._onButtonPress.bind(this))
  • extension.js:188
    this._buttonReleaseId = this._overlay.connect('button-release-event', this._onButtonRelease.bind(this))
  • extension.js:190
    this._keyPressId = this._overlay.connect('key-press-event', this._onKeyPress.bind(this))
  • extension.js:189
    this._motionId = this._overlay.connect('motion-event', this._onMotion.bind(this))

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

dznas auto- rejected
Auto-rejected because of new version 2 was uploaded