Review of "Lupa OCR" version 3

Details Page Preview

Capture text from screen with OCR and search the web instantly. Like Google's Circle to Search but built into GNOME.

Extension Homepage
https://github.com/dznass-cmd/lupa-ocr-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • extension.js:487
    St.Clipboard.get_default()
  • extension.js:493
    St.Clipboard.get_default()

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • extension.js:208
    this._buttonPressId = this._overlay.connect('button-press-event', this._onButtonPress.bind(this))
  • extension.js:209
    this._buttonReleaseId = this._overlay.connect('button-release-event', this._onButtonRelease.bind(this))
  • extension.js:211
    this._keyPressId = this._overlay.connect('key-press-event', this._onKeyPress.bind(this))
  • extension.js:210
    this._motionId = this._overlay.connect('motion-event', this._onMotion.bind(this))

All Versions

Version Status
4 Unreviewed
3 Rejected
2 Rejected
1 Rejected

Previous Reviews on this Version

dznas auto- rejected
Auto-rejected because of new version 4 was uploaded