Review of "Keychron K5 Pro Controls" version 2

Details Page Preview

Panel controls, battery status, lighting profiles and wired VIA RGB controls for the Keychron K5 Pro.

Extension Homepage
https://github.com/Royza/Keychron-K5-Pro-Gnome-Ext

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 3

Shexli found 3 issues that may need reviewer attention.

EGO-L-002 warning

objects created by extension should be destroyed in disable()

Objects assigned in `enable()` are missing matching `.destroy()` calls in `disable()` or its helper methods.

Destroy all objects

  • controller.js:142
    this._statusItem = new PopupMenu.PopupMenuItem('Keyboard', {reactive: false})

EGO-L-005 warning

owned object references should be released in disable()

Owned references that are cleaned up in `disable()` should also be released with `null` or `undefined`.

Destroy all objects

  • controller.js:142
    this._statusItem = new PopupMenu.PopupMenuItem('Keyboard', {reactive: false})

EGO-L-003 warning

signals connected by extension should be disconnected in disable()

Signals assigned in `enable()` are missing matching disconnect calls in `disable()` or its helper methods.

Disconnect all signals

  • controller.js:127
            this.menu.connect('open-state-changed', (_menu, open) => {
                if (open)
                    this._extension.refreshState();
                else
                    this._extension.flushPendingLightingSave();
            })

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

JustPerfection active