Review of "Keychron K5 Pro Controls" version 4

Details Page Preview

Panel controls, battery status, lighting profiles and wired VIA RGB controls for the Keychron K5 Pro.

Extension Homepage
https://github.com/Royza/Keychron-K5-Pro-Gnome-Ext

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) warning 1

Shexli found 1 issue that may need reviewer attention.

EGO-A-004 warning

extension files should not contain excessive ungated console logging

File contains 7 ungated console.log/warn/error calls (threshold: 5).

No excessive logging

  • controller.js:3330
    console.error(`${APPLICATION_NAME}: ${error.message}`)
  • controller.js:3673
    console.error(`${APPLICATION_NAME}: profile capture failed: ${error.message}`)
  • controller.js:3759
                    console.error(
                        `${APPLICATION_NAME}: active profile persistence failed: ${error.message}`
                    )
  • controller.js:3784
    console.error(`${APPLICATION_NAME}: profile apply failed: ${error.message}`)
  • controller.js:3923
    console.error(`${APPLICATION_NAME}: brightness key setup failed: ${error.message}`)
  • controller.js:3951
    console.error(`${APPLICATION_NAME}: failed to release ${name}: ${error.message}`)
  • controller.js:3966
    console.error(`${APPLICATION_NAME}: failed to restore ${key}: ${error.message}`)

All Versions

Version Status
5 Unreviewed
4 Rejected
3 Rejected
2 Active
1 Rejected

Previous Reviews on this Version

Roizo auto- rejected
Auto-rejected because of new version 5 was uploaded