Review of "Vicinae" version 1.7.1 (11)

Details Page Preview

Gnome extension for vicinae launcher to expose clipboard and window managment APIs.

Extension Homepage
https://github.com/vicinaehq/gnome-extension

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 manual_review 1

Shexli found 2 issues that may need reviewer attention.

EGO-A-005 manual_review

extensions should not access the clipboard directly

Direct clipboard access via `St.Clipboard.get_default()` requires reviewer scrutiny.

Review Guidelines

  • core/clipboard/clipboard-manager.js:22
    St.Clipboard.get_default()

EGO-C49-004 error

extensions targeting GNOME 49 must not call Meta.Window.get_maximized

This extension explicitly targets GNOME Shell 49 but still calls removed `Meta.Window.get_maximized()`.

Meta.Window

  • utils/window-utils.js:55
    win.get_maximized()

All Versions

Version Status
1.7.2 (12) Active
1.7.1 (11) Rejected
1.7.0 (10) Active
1.6.2 (9) Active
1.6.1 (8) Active
1.6.0 (7) Active
1.5.3 (6) Active
1.5.2 (5) Rejected
1.5.1 (4) Rejected
1.5.0 (3) Rejected
1.4.0 (2) Rejected
1.3.0 (1) Rejected

Previous Reviews on this Version

JustPerfection rejected
1. Selective disable isn't allowed (line 40 `core/clipboard/clipboard-manager.js`). 2. Please use aysnc for reading file content since you are in shell process (line 7 `utils/issue-report.js`): [Gio.File.load_contents_async](https://gjs-docs.gnome.org/gio20~2.0/gio.file#method-load_contents_async) 3. Remove line 17-32 `utils/issue-report.js`. We have `misc.config.PACKAGE_VERSION`: [Port Guide 40: Shell version](https://gjs.guide/extensions/upgrading/gnome-shell-40.html#checking-gnome-shell-version)
JD posted a review
"1. Selective disable isn't allowed (line 40 `core/clipboard/clipboard-manager.js`)." I don't understand this one...can you explain a little more.
JustPerfection posted a review
`disable` shouldn't be blocked by that check. Remove line 40 and 44 `core/clipboard/clipboard-manager.js` and that will fix it.
JD posted a review
okay got it, thank you