Review of "WACK - Sonoma Lockscreen" version 1.7.0 (29)

Details Page Preview

macOS Sonoma-inspired lock screen for GNOME Shell. Part of the WACK Project.

Extension Homepage
https://github.com/rinzler69-wastaken/wack-sonoma-lockscreen

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental)

Shexli did not find any issues.

All Versions

Version Status
1.7.0 (31) Active
1.7.0 (30) Rejected
1.7.0 (29) Rejected
1.6.4 (28) Active
1.6.3 (27) Active
1.6.2 (26) Active
1.6.1 (25) Inactive
1.6.0 (24) Inactive
1.6.0 (23) Rejected
1.6.0 (22) Rejected
1.6.0 (21) Rejected
1.6.0 (20) Rejected
1.6.0 (19) Rejected
1.5.0 (18) Rejected
1.4.0 (17) Inactive
1.3.4 (16) Inactive
1.3.2 (15) Inactive
1.3.0 (14) Inactive
1.3.0 (13) Rejected
1.3.0 (12) Inactive
1.3.0 (11) Rejected
1.2.2 (10) Inactive
1.2.0 (9) Inactive
1.2.0 (8) Rejected
1.1.2 (7) Inactive
1.1.2 (6) Rejected
1.1.1 (5) Inactive
1.1.0 (4) Rejected
3 Rejected
2 Inactive
1 Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Where did you find that info (line 209-214 `extension.js`)?
rinzler69 posted a review
This information comes directly from GNOME Shell's upstream source code: `js/ui/unlockDialog.js` (line ~803 in GNOME 45+, `UnlockDialog._updateBackgroundEffects()`). Why it is used: GNOME Shell's default `UnlockDialog` automatically applies a `Shell.BlurEffect` to all children of `_backgroundGroup` inside `_updateBackgroundEffects()`. When our extension applies a custom lockscreen wallpaper overlay, overriding `_updateBackgroundEffects()` is required so GNOME Shell does not stomp or overwrite our custom wallpaper's contrast and blur settings during scale factor updates or state changes. (Note: Line 210 contained a leftover unused variable `const lockDialogGroup = ...` which will be removed, should this update be rejected.)
rinzler69 posted a review
P.S tried removing that 'unused' line and it broke the extension
JustPerfection posted a review
What's the error? `_updateUserSwitchVisibility` is never removed: - [Main](https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/749c4b8f05aeb27ae87cdf259cdc777a6d2f549e/js/ui/unlockDialog.js#L1057) - [50](https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/91c0d29a03e495db2a75cc45853b46845bf5a143/js/ui/unlockDialog.js#L920) - [49](https://gitlab.gnome.org/GNOME/gnome-shell/-/blob/6dfd1b56a6002ae09868a257302c9f2e15b5309a/js/ui/unlockDialog.js#L909)
rinzler69 posted a review
the error was "lockDialog is not defined". i suppose that was one important thing that made the extension work the way it should?
rinzler69 posted a review
Ah, thank you for clarifying! I misunderstood your initial question. We hook dialog._updateUserSwitchVisibility to ensure dialog._otherUserButton stays hidden whenever Cupertino lockscreen mode is active. The comment mentioning that it was "removed/renamed in 50.1" was an error on our part from testing on a custom build — thank you for pointing out the upstream GNOME Shell source links! I have updated the comment in the source code to accurately reflect the hook's purpose and verified that _origUpdateUserSwitchVisibility is cleanly restored in disable().
rinzler69 auto- rejected
Auto-rejected because of new version 1.7.0 (30) was uploaded