Review of "ScreenSaver" version 1.0.0 (1)

Details Page Preview

A fork of LiveLockScreen that rotates images as your lock screen background.

Extension Homepage
https://github.com/rmacordeiro/ScreenSaver

No comments.

FAQ

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 4

Shexli found 5 issues that may need reviewer attention.

EGO-C49-002 error

extensions targeting GNOME 49 must not use removed Clutter action classes

This extension explicitly targets GNOME Shell 49 but still uses removed `Clutter.ClickAction` or `Clutter.TapAction`.

Clutter.ClickAction() and Clutter.TapAction()

  • extension.js:290
    new Clutter.TapAction()

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Package contains files that often should not be shipped for review.

Don't include unnecessary files

  • .gitignore
    .gitignore

EGO-P-006 warning

unnecessary build and translation artifacts should not be shipped

Compiled GSettings schemas should not be shipped for 45+ packages.

Don't include unnecessary files

  • schemas/gschemas.compiled
    schemas/gschemas.compiled

EGO-P-007 warning

JavaScript files should be reachable from extension.js or prefs.js

Some JavaScript files are not reachable from `extension.js` or `prefs.js` imports.

Don't include unnecessary files

  • utils/shell_version_dbus.js

EGO-M-008 warning

extensions using unlock-dialog must document it in disable() comments

Extensions using `unlock-dialog` should document the reason in `disable()` comments.

Session Modes

  • extension.js:466
        disable() {
            destroySleeps();
    
            if (this._injectRetryId) {
                GLib.source_remove(this._injectRetryId);
                this._injectRetryId = 0;
            }
            if (this._blurEffectTimeoutId) {
                GLib.source_remove(this._blurEffectTimeoutId);
                this._blurE

All Versions

Version Status
1.0.3 (5) Active
1.0.2 (4) Rejected
1.0.1 (3) Active
1.0.0 (2) Rejected
1.0.0 (1) Rejected

Previous Reviews on this Version

JustPerfection waiting for author
Is this fork of the other extension? and why aren't you sending merge request to the original instead of creating a new one?
rmacordeiro posted a review
It is based on a fork, but the original is for videos, I removed the videos and changed it to be a slideshow, mimicking an old sreensaver solution that used to exist some years ago on X11. In the end the features are completely different.
rmacordeiro posted a review
How can I upload a new version, solving the mentioned issues above?
JustPerfection posted a review
You can upload the next version the same way you uploaded this one.
rmacordeiro auto- rejected
Auto-rejected because of new version 1.0.0 (2) was uploaded